Port changes to include data transfer #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminRodenberg
requested changes
Jul 20, 2020
There was a problem hiding this comment.
Just checked the solverdummy and it runs. One thing I find a bit irritating is that we print the readData for this solverdummy, while the other solverdummies from precice/precice#750 do not print any readData. Output:
readData: 3.0000000000000000 3.0000000000000000 3.0000000000000000 4.0000000000000000 4.0000000000000000 4.0000000000000000 5.0000000000000000 5.0000000000000000 5.0000000000000000
Co-authored-by: Benjamin Rüth <benjamin.rueth@tum.de>
BenjaminRodenberg
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the changes applied in precice/precice#750 into the Fortran module solverdummy.
It is ready for review, but waiting for precice/precice#750 to be merged first.
Closes #2.