Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 2d axisymmetric cases #228

Closed
arvedes opened this issue Apr 29, 2022 · 8 comments · Fixed by #246
Closed

Enable 2d axisymmetric cases #228

arvedes opened this issue Apr 29, 2022 · 8 comments · Fixed by #246
Assignees
Milestone

Comments

@arvedes
Copy link

arvedes commented Apr 29, 2022

For 2d cases with a wedge for axisymmetric simulation this causes an error. I'd suggest to change that to a warning.

FatalErrorInFunction

arvedes added a commit to arvedes/openfoam-adapter that referenced this issue Apr 29, 2022
@davidscn
Copy link
Member

davidscn commented May 2, 2022

That's indeed something I did not yet consider. I'm a bit afraid that a warning is not enough as OpenFOAM has a very verbose output and also preCICE (potentially also the adapter) prints out information on the terminal so that the warning disappears rather quick. I would rather introduce a boolean configuration parameter in order to only pass through this line in case it was explicitly enabled.

@arvedes
Copy link
Author

arvedes commented May 2, 2022

That would also be an option. I implemented the warning here, it works well: https://github.com/arvedes/openfoam-adapter

@precice-bot
Copy link

This issue has been mentioned on preCICE Forum on Discourse. There might be relevant details there:

https://precice.discourse.group/t/using-openfoam-adapter-with-axisymmetric-mesh/598/4

@MakisH MakisH added this to the v1.1.1 milestone May 25, 2022
@MakisH MakisH modified the milestones: v1.1.1, v1.2.0 Sep 19, 2022
MakisH added a commit that referenced this issue Sep 19, 2022
This adds support for axisymmetric cases, closes #228.

co-authored-by: arved.enders-seidlitz@posteo.de
@MakisH MakisH self-assigned this Sep 19, 2022
@Habaw27
Copy link

Habaw27 commented Aug 21, 2023

Hello arvedes
I tried to run a 2D axisymmetric case with the modification you suggested but still an error occurs from Utilities.C file and stops.
How did you solve this issue?
Thank you

@arvedes
Copy link
Author

arvedes commented Aug 22, 2023

My simulations worked well with this fix. What error message do you get?
Did you try to run without coupling?

@Habaw27
Copy link

Habaw27 commented Aug 22, 2023 via email

@arvedes
Copy link
Author

arvedes commented Aug 23, 2023

Dear Habib,
Good to hear that you resolved the OpenFOAM issue. Unfortunately, I don't have any experience with deal.II myself, so I may not be able to offer much assistance. However, I would suggest asking for help on the forum at https://precice.discourse.group/. I hope you're able to find a solution to your issue soon!
Best,
Arved

@Habaw27
Copy link

Habaw27 commented Aug 23, 2023

Dear arvedes,
Thank you very much for you help. I will ask my problems on the forum you suggested.
Regards
Habib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants