Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the system tests (attempt 2) #327

Closed
wants to merge 4 commits into from
Closed

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Mar 21, 2024

This is meant as a demonstration of using the system tests on adapter pull requests.

I introduced a bug in the force generation, which should make the perpendicular-flap test fail, but the flow-over-heated-plate test pass. These tests are defined in https://github.com/precice/tutorials/blob/develop/tools/tests/tests.yaml

Documentation: https://precice.org/dev-docs-system-tests.html

To trigger the tests, add the trigger-system-tests label.

Note: The source branch needs to be in the repository, not in a fork.

@MakisH
Copy link
Member Author

MakisH commented Mar 21, 2024

The flow-over-heated-plate seems to be failing because the .init.vtk and .final.vtk files are missing:

field-compare-1  | [ ======= ] 408 file comparisons performed
field-compare-1  | [ PASSED  ] 400 file comparisons
field-compare-1  | [ FAILED  ] 8 file comparisons, listed below:
field-compare-1  | [ FAILED  ] Solid-Mesh-Solid.final.vtk: (Missing source file)
field-compare-1  | [ FAILED  ] Fluid-Mesh-Solid.final.vtk: (Missing source file)
field-compare-1  | [ FAILED  ] Solid-Mesh-Fluid.final.vtk: (Missing source file)
field-compare-1  | [ FAILED  ] Fluid-Mesh-Fluid.final.vtk: (Missing source file)
field-compare-1  | [ FAILED  ] Fluid-Mesh-Fluid.init.vtk: (Missing reference file)
field-compare-1  | [ FAILED  ] Fluid-Mesh-Solid.init.vtk: (Missing reference file)
field-compare-1  | [ FAILED  ] Solid-Mesh-Solid.init.vtk: (Missing reference file)
field-compare-1  | [ FAILED  ] Solid-Mesh-Fluid.init.vtk: (Missing reference file)

The bundled reference_results.metadata still shows preCICE v2.5.0, which is strange, as I have already updated the reference results in develop. @valentin-seitz any clue what is going on here?

@MakisH
Copy link
Member Author

MakisH commented Mar 21, 2024

Without the bug, the tests are passing: https://github.com/precice/openfoam-adapter/actions/runs/8372394839/job/22923281466?pr=327

With the (intended) bug, the perpendicular-flap test fails, as expected: https://github.com/precice/openfoam-adapter/actions/runs/8372512988/job/22923623135?pr=327

@MakisH MakisH closed this Mar 21, 2024
@MakisH MakisH deleted the test-system-tests branch March 21, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant