Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove meshName from solverdummies input arguments #829

Closed
BenjaminRodenberg opened this issue Jul 20, 2020 · 1 comment · Fixed by #1256
Closed

Remove meshName from solverdummies input arguments #829

BenjaminRodenberg opened this issue Jul 20, 2020 · 1 comment · Fixed by #1256
Assignees
@IshaanDesai
Labels
enhancement A new feature, a new functionality of preCICE (from user perspective) thesis This issue could be a student thesis / project, i.e. it has some scientific value and a certain size
Milestone
Version 2.4.0

Comments

@BenjaminRodenberg
Copy link
Member

See comment #750 (comment).

Let's remove meshName from the solverdummies input arguments, since it is somehow redundant to the solverNameand hardcode it.

This will also require us to update our tests accordingly.
@BenjaminRodenberg BenjaminRodenberg added enhancement A new feature, a new functionality of preCICE (from user perspective) thesis This issue could be a student thesis / project, i.e. it has some scientific value and a certain size labels Jul 20, 2020
@BenjaminRodenberg BenjaminRodenberg added this to the Version 2.2.0 milestone Jul 20, 2020
@BenjaminRodenberg BenjaminRodenberg mentioned this issue Jul 20, 2020
Merged
@IshaanDesai IshaanDesai mentioned this issue Jul 20, 2020
Closed
@BenjaminRodenberg BenjaminRodenberg self-assigned this Oct 27, 2020
@BenjaminRodenberg
Copy link
Member Author

Since 2.2.0 is a minor release we should try to avoid breaking code. I would suggest to use a reasonable default, if meshName is not provided. If a user provides meshName we can accept it, but throw a deprecation warning. We can then finally remove meshName in 3.0.0.

@IshaanDesai IshaanDesai linked a pull request Apr 22, 2022 that will close this issue
Remove meshName from solverdummies input arguments #1256
Merged
7 tasks
@fsimonis fsimonis removed their assignment Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IshaanDesai IshaanDesai

Labels
enhancement A new feature, a new functionality of preCICE (from user perspective) thesis This issue could be a student thesis / project, i.e. it has some scientific value and a certain size
Projects
None yet
Milestone
Version 2.4.0
Development

Successfully merging a pull request may close this issue.

Remove meshName from solverdummies input arguments IshaanDesai/precice
3 participants
@BenjaminRodenberg @fsimonis @IshaanDesai