-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds breaking dam test cases #279
Conversation
Thanks for adding this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some comments for the 2D version, please apply the same to the 3D as well, and I will review again. Most of the comments are one-click suggestions, so it shouldn't take too long to integrate most of the feedback.
It would be great if you could integrate this feedback today/tomorrow, so that we can proceed with the next round and merge it before the workshop. I could then include something in the news talk as well! 😉
breaking-dam-2d/fluid-openfoam/0/uniform/functionObjects/functionObjectProperties
Outdated
Show resolved
Hide resolved
All changes added. |
This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there: |
This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there: https://precice.discourse.group/t/question-about-using-overset-mesh-in-fsi-two-way-coupling/1446/4 |
This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there: |
1cf6328
to
c579937
Compare
Ready for re-review @MakisH
Please:
|
This reverts commit 9e011d9.
This reverts commit f6f10ad.
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
@uekerman I went ahead and fixed most of the trivial issues. Still open:
|
By setting the |
With the current setup, the simulation final crashes at 1.435: I assume we are losing mass somewhere, so maybe we need to check the boundary conditions again. Maybe the For context, if I use the same |
My last state 9b97b92 does indeed crash, but only at t=1.485. |
That setup is indeed not stiff enough (i.e. the forces here are too high). (The fluid here is different from the one there) |
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
With a reduced water column height (1/2 height instead of 3/4 height) and a reduced timestep size (2e-3), I can run until t=5. Probably still sensitive, but good enough in my opinion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The simulation now completes for me (for 1s, I trust your runs for 5s) and everything else looks clean.
Thank you for pushing this through the finish line!
This PR adds a breaking dam 2D and breaking dam 3D test case for multiphase flow of water/air mixture, where a body of water strikes a solid, deformable wall.