Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds breaking dam test cases #279

Merged
merged 46 commits into from
Mar 11, 2024
Merged

Adds breaking dam test cases #279

merged 46 commits into from
Mar 11, 2024

Conversation

KyleDavisSA
Copy link
Contributor

@KyleDavisSA KyleDavisSA commented Jun 29, 2022

This PR adds a breaking dam 2D and breaking dam 3D test case for multiphase flow of water/air mixture, where a body of water strikes a solid, deformable wall.

@uekerman uekerman changed the base branch from master to develop June 30, 2022 07:47
@uekerman
Copy link
Member

Thanks for adding this!
Could you please add a README describing the case?
Please also check the conventions here: https://precice.org/community-contribute-to-precice.html#contributing-tutorials

@KyleDavisSA KyleDavisSA self-assigned this Jan 31, 2023
@KyleDavisSA KyleDavisSA changed the title Adds breaking dam 2D test case Adds breaking dam test cases Jan 31, 2023
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some comments for the 2D version, please apply the same to the 3D as well, and I will review again. Most of the comments are one-click suggestions, so it shouldn't take too long to integrate most of the feedback.

It would be great if you could integrate this feedback today/tomorrow, so that we can proceed with the next round and merge it before the workshop. I could then include something in the news talk as well! 😉

breaking-dam-2d/fluid-openfoam/0/U Outdated Show resolved Hide resolved
breaking-dam-2d/fluid-openfoam/0/alpha.water Outdated Show resolved Hide resolved
breaking-dam-2d/fluid-openfoam/0/alpha.water Outdated Show resolved Hide resolved
breaking-dam-2d/fluid-openfoam/0_orig/alpha.water Outdated Show resolved Hide resolved
breaking-dam-2d/README.md Outdated Show resolved Hide resolved
breaking-dam-2d/README.md Outdated Show resolved Hide resolved
breaking-dam-3d/README.md Outdated Show resolved Hide resolved
breaking-dam-3d/fluid-openfoam/0_orig/U Outdated Show resolved Hide resolved
breaking-dam-3d/README.md Outdated Show resolved Hide resolved
@KyleDavisSA
Copy link
Contributor Author

All changes added.

@precice-bot
Copy link
Collaborator

This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there:

https://precice.discourse.group/t/can-i-use-precice-to-simulate-a-droplet-impacting-on-an-elastic-substrate/1372/2

@precice-bot
Copy link
Collaborator

This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there:

https://precice.discourse.group/t/question-about-using-overset-mesh-in-fsi-two-way-coupling/1446/4

@precice-bot
Copy link
Collaborator

This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there:

https://precice.discourse.group/t/mppicfoam-precice/1783/2

@uekerman
Copy link
Member

uekerman commented Mar 4, 2024

Ready for re-review @MakisH

  • Updated to preCICE v3
  • Removed the 3D case. Will open a separate draft PR (beyond this distribution)
  • Changed the setup to have "z" in span-wise direction. This way, we can use 2D as preCICE mesh dimensions. To this end, I copied the perpendicular flap meshes for both solvers.
  • I then had to increase the stiffness of the flap to make the case work.

Please:

  • Double-check, fix, or clean the OpenFOAM input files. Not much that I changed here.
  • Sanity-check on conventions

@MakisH
Copy link
Member

MakisH commented Mar 10, 2024

@uekerman I went ahead and fixed most of the trivial issues. Still open:

  • The simulation diverges for me. With your setup and the updated gravity, it diverges at 0.79. I tried making the flap stiffer, the fluid time step size smaller, but I could not achieve anything better, and it looks like we need a better solution.
  • This case currently is set up using two meshes, relying only on pointDisplacement in the OpenFOAM style (old-style tutorials). I will try merging to a single mesh, maybe this already helps.
  • We are using a fixed time step size for the flow simulation, which is generally a no-go for two-phase simulations. I don't know if subcycling works correctly, but it does not help (breaks earlier, the moment the water touches the pillar).

@MakisH
Copy link
Member

MakisH commented Mar 10, 2024

I switched the case to use one mesh, and this already helped a lot. The simulation now crashes later, at 0.945:

Screenshot from 2024-03-10 23-52-28

Maybe it is something with the outlet condition now.

@MakisH
Copy link
Member

MakisH commented Mar 10, 2024

By setting the upperWall to zeroGradient, the simulation completes (due to the max-time-windows) at 1.0.

@MakisH
Copy link
Member

MakisH commented Mar 10, 2024

With the current setup, the simulation final crashes at 1.435:

Screenshot from 2024-03-11 00-12-24

I assume we are losing mass somewhere, so maybe we need to check the boundary conditions again. Maybe the zeroGradient for the alpha.water was not such a smart choice in the end.

For context, if I use the same solid-calculix as with the perpendicular-flap, then the simulation crashes now at 0.79 with an abnormally deformed flap (shape change).

@uekerman
Copy link
Member

My last state 9b97b92 does indeed crash, but only at t=1.485.
CalculiX adapter: precice/calculix-adapter@ffeda14 (same as you)
OpenFOAM: OpenFOAM-2212
OpenFOAM adapter: precice/openfoam-adapter@b6e860ae79a35

Screenshot from 2024-03-11 14-02-17

@uekerman
Copy link
Member

For context, if I use the same solid-calculix as with the perpendicular-flap, then the simulation crashes now at 0.79 with an abnormally deformed flap (shape change).

That setup is indeed not stiff enough (i.e. the forces here are too high). (The fluid here is different from the one there)

Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
@uekerman
Copy link
Member

uekerman commented Mar 11, 2024

Latest state here 27d3fd7 crashes at t=1.24.

With the old alpha.water (reverting a9cdff1), it crashes at t=0.91.

@uekerman
Copy link
Member

With a reduced water column height (1/2 height instead of 3/4 height) and a reduced timestep size (2e-3), I can run until t=5. Probably still sensitive, but good enough in my opinion.

Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The simulation now completes for me (for 1s, I trust your runs for 5s) and everything else looks clean.

Thank you for pushing this through the finish line!

@MakisH MakisH merged commit b695af0 into develop Mar 11, 2024
3 checks passed
@MakisH MakisH deleted the breaking-dam-2d branch March 11, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants