Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Docker compose root user problem #354 #355

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Fixed Docker compose root user problem #354 #355

merged 1 commit into from
Aug 3, 2023

Conversation

valentin-seitz
Copy link
Member

@valentin-seitz valentin-seitz commented Aug 2, 2023 •
edited
Loading

This solves #354

Solution:

  • first get the User & Group ID of the current user via a subprocess call
  • write out a .env file
  • docker compose will then use this and substitute ${UID} and ${GID}

It did not break the action: see https://github.com/precice/tutorials/actions/runs/5740269267

MakisH
MakisH approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense.
I tried running the tests locally, and I can now remove the ./run/ directory as my regular user.

@MakisH MakisH merged commit f9bcb48 into develop Aug 3, 2023
5 checks passed
@MakisH MakisH deleted the fix-docker-compose-root-user branch August 3, 2023 09:21
@MakisH MakisH mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MakisH MakisH MakisH approved these changes

Assignees

@valentin-seitz valentin-seitz

Labels
bug student systemtests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@valentin-seitz @MakisH