Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEniCS OpenFOAM perp-flap and cyl-flap #38

Merged
merged 55 commits into from
Aug 16, 2019

Conversation

richahert
Copy link
Contributor

@richahert richahert commented Jul 9, 2019

I implemented the perpendicular flap with FEniCS and OpenFOAM.
It comes with a new Fluid Case that is almost the same as for OF-CcX but since FEniCS is in 2D I changed the thickness to 1.

There is still some code in perp-flap.py that is not relevant for a tutorial that can be deleted.

The displacements are smaller than expected for unknown reasons.

It makes sense to merge this PR together with precice/fenics-adapter#38, the PR brings FSI functionality to the fenics-adapter.

ToDos: perp-flap

ToDos: cyl-flap

@BenjaminRodenberg
Copy link
Member

With the version of the fenics-adapter on this branch I can run the example and the results look reasonable. There are some open points, though:

  • The 2D-3D coupling is not handled properly. While the Fluid "lives" in the XZ plane, the Solid "lives" in XY plane. The coupling seems to work properly, therefore this is mainly a visualization issue.
  • Some information in the README.md on expected output and hints for visualization would be good. You can also use the wiki for this. I already created a new page here.

@BenjaminRodenberg BenjaminRodenberg changed the title WIP: FEniCS OpenFOAM perp-flap WIP: FEniCS OpenFOAM perp-flap and cyl-flap Jul 31, 2019
@BenjaminRodenberg
Copy link
Member

The 2D-3D coupling is not handled properly. While the Fluid "lives" in the XZ plane, the Solid "lives" in XY plane. The coupling seems to work properly, therefore this is mainly a visualization issue.

Regarding this I added richahert/fenics-adapter@2c9c2a0. This removes the entire swapping of coordinates from the adapter. I think we should try to fix the test cases instead. This means that quasi-2D OpenFOAM simulations should not live in the XZ plane, but in the XY plane. This makes the adapter much cleaner and also solves the visualization issue mentioned above.

@richahert
Copy link
Contributor Author

Now the physics should be correct. The results for the FSI3 look very much like the deal.ii-OpenFOAM example. deformations are bigger than in the benchmark because of the linear elastic material instead of St. Venant Kirchhoff material in the original FSI3.
fsi3

@richahert richahert changed the title WIP: FEniCS OpenFOAM perp-flap and cyl-flap FEniCS OpenFOAM perp-flap and cyl-flap Aug 14, 2019
@BenjaminRodenberg
Copy link
Member

* delete `Fluid_1.vtk`

see #38 (comment)

is still necessary. I think this is an issue of the adapter. Therefore, let's not worry anymore about this here. I opened an issue: precice/openfoam-adapter#95

The rest of the flap tutorial looks very nice!

@BenjaminRodenberg
Copy link
Member

I cannot run the OpenFOAM Fluid case for the FSI3 benchmark using OpenFOAM 6. @richahert did you use OpenFOAM 5 or older? Did this work?

I will try to find out how to fix it for OpenFOAM 6.

@BenjaminRodenberg
Copy link
Member

Both tutorials are now running on my machine. See #40 regarding compatibility problems with OpenFOAM6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants