Add GitHub action for vagrant up #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should probably fail
…openfoam2012 session
Merged
MakisH
added a commit
that referenced
this pull request
Apr 30, 2021
* Make provisioning scripts run in unprivileged mode + more (#17) * Move install-vscode to home * Enable object files clean-up by default * Move cleanup steps to cleanup.sh * Add GitHub action to lint shell scripts (#18) * Add GitHub action for vagrant up + a few fixes (#19) * Add code_aster (#20) * Disable screensaver and screen lock (#21) * Update README, add instructions for testing * Add alias for config-visualizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a GitHub Actions workflow to provision the box (run
vagrant up), as described in https://github.com/jonashackt/vagrant-github-actions The goal is to check building from a clean state, as usually I try to re-provision while developing. This already helped me find an issue with OpenFOAM that I had not noticed before for this very reason.Unfortunately, nested virtualization is not supported in Linux runners, only on macOS runners. I am using the currently latest "stable" image
macos-10.15.This also packages the box and uploads it to the artifacts, retaining it for 7 days. The artifact is expected to be ~4-5GB.
Publishing is not covered here: Would be additional work to setup right now, while I prefer doing releases when I feel this is needed. The labor hurdle for publishing once in a while is not really significant here.
This workflow should run only when a PR is marked as "ready for review", to save resources, as each job should take a long time (~1h). The time limits seem to be enough (6h/job).
Additional side-fixes:
~with${HOME}in environment variables for portability: the run scripts, for example, do not understand~.openfoam2012session instead of loading the OpenFOAM bashrc file: it was causing strange unrelated errors, probably due to shell incompatibilities.