Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed confusing labels #625 #631

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Changed confusing labels #625 #631

merged 2 commits into from
Jun 17, 2024

Conversation

jinamshah
Copy link
Collaborator

  • Changed “List View” to “Crop List”
  • Changed “Calendar View” to “Crop Calendar”
  • Changed “View My List” to “My Selected Crops”

@jinamshah jinamshah self-assigned this Jun 7, 2024
@jinamshah jinamshah linked an issue Jun 7, 2024 that may be closed by this pull request
@mikahpinegar
Copy link
Contributor

Your review app has been deployed and is available at 'http://48.217.220.9:80'.

Learn More about how to test and provide feedback for the app.

1 similar comment
@mikahpinegar
Copy link
Contributor

Your review app has been deployed and is available at 'http://48.217.220.9:80'.

Learn More about how to test and provide feedback for the app.

@mikahpinegar
Copy link
Contributor

Your review app has been deployed and is available at 'http://48.217.220.9:80'.

Learn More about how to test and provide feedback for the app.

1 similar comment
@mikahpinegar
Copy link
Contributor

Your review app has been deployed and is available at 'http://48.217.220.9:80'.

Learn More about how to test and provide feedback for the app.

@@ -87,7 +87,7 @@ const ProgressButtonsInner = ({
onClick={() => (progressRedux === 4 ? setMyCoverCropActivationFlag() : changeProgress('increment'))}
disabled={isDisabledNext || (progressRedux === 4 && selectedCropIdsRedux.length === 0)}
>
{progressRedux === 4 ? 'VIEW MY LIST' : 'NEXT'}
{progressRedux === 4 ? 'MY SELECTED CROPS' : 'NEXT'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing this text has left the button with 2 rows of text. Can you please adjust the size of the button so we can see how it looks when the text is on just one line. I can see we are adjusting the size of the button for this text already i just think it needs to be a little bigger so the text is on one line.

@mikahpinegar
Copy link
Contributor

Your review app has been deployed and is available at 'http://48.217.220.9:80'.

Learn More about how to test and provide feedback for the app.

1 similar comment
@mikahpinegar
Copy link
Contributor

Your review app has been deployed and is available at 'http://48.217.220.9:80'.

Learn More about how to test and provide feedback for the app.

@Adamws33 Adamws33 merged commit de9e7e9 into develop Jun 17, 2024
2 checks passed
@Adamws33 Adamws33 deleted the fix/confusing_labels branch June 17, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear up confusing labels
3 participants