Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues with .d.ts generation #411

Merged
merged 15 commits into from Sep 8, 2021

Conversation

emmatown
Copy link
Member

@emmatown emmatown commented Sep 7, 2021

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2021

🦋 Changeset detected

Latest commit: 03ac650

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preconstruct/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #411 (785c843) into main (4b8e443) will increase coverage by 0.51%.
The diff coverage is 82.50%.

❗ Current head 785c843 differs from pull request most recent head 03ac650. Consider uploading reports for the commit 03ac650 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
+ Coverage   89.62%   90.13%   +0.51%     
==========================================
  Files          32       31       -1     
  Lines        1349     1298      -51     
  Branches      341      346       +5     
==========================================
- Hits         1209     1170      -39     
+ Misses        136      123      -13     
- Partials        4        5       +1     
Impacted Files Coverage Δ
packages/cli/src/logger.ts 75.00% <80.00%> (+1.66%) ⬆️
...lugins/typescript-declarations/create-generator.ts 75.82% <82.14%> (-0.08%) ⬇️
packages/cli/src/errors.ts 80.00% <100.00%> (ø)
...rc/rollup-plugins/typescript-declarations/index.ts 97.22% <100.00%> (ø)
packages/cli/src/build/index.ts 92.53% <0.00%> (+1.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b8e443...03ac650. Read the comment docs.

@emmatown emmatown merged commit ce31841 into main Sep 8, 2021
@emmatown emmatown deleted the alternative-typescript-declaration-generation branch September 8, 2021 00:46
@github-actions github-actions bot mentioned this pull request Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant