Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoRAX-compatible GPT-2 #109

Merged
merged 8 commits into from
Dec 7, 2023
Merged

LoRAX-compatible GPT-2 #109

merged 8 commits into from
Dec 7, 2023

Conversation

geoffreyangus
Copy link
Contributor

Adds LoRAX for GPT-2 with support for the following target modules:

  • transformer.h.{layer}.attn.c_attn
  • transformer.h.{layer}.attn.c_proj
  • transformer.h.{layer}.mlp.c_fc
  • transformer.h.{layer}.mlp.c_proj

Copy link
Contributor

@tgaddair tgaddair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Few comment, couple things were marked resolved but aren't (possibly haven't pushed code?).

Copy link
Contributor

@tgaddair tgaddair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants