Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sync script to account for subfolder bucket paths #135

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

noyoshi
Copy link
Collaborator

@noyoshi noyoshi commented Dec 15, 2023

  • The sync script would fail if HF_CACHE_BUCKET is not just a bucket, but a bucket + a subfolder
  • Added in extra check to ensure that if that is the case, it will still work.

The files variable will have everything except for the bucket, even the bucket's subfolder, so we should ensure that when we construct the S3 path we exclude any subfolders in the bucket env variable.

@noyoshi noyoshi merged commit 2fae25e into main Dec 15, 2023
@noyoshi noyoshi deleted the fix-sync-script branch December 15, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants