Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update s3.py #234

Merged
merged 1 commit into from
Feb 10, 2024
Merged

Update s3.py #234

merged 1 commit into from
Feb 10, 2024

Conversation

llama-shepard
Copy link
Contributor

What does this PR do?

This PR is a fix for lorax.errors.GenerationError: Request failed during generation: Server error: Can't find 'adapter_config.json' at '/data/models--s3:----adapters--gsm8k/snapshots'

The adapter is getting downloaded to models--{model_id}/snapshots folder. But get_local_path is returning path "/data/models--s3:----{bucket}--{model_id}/snapshots".

This fix returns the "models--{model_id}/snapshots" path

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Was this discussed/approved via a Github issue or the discord / slack channel? Please add a link
    to it if that's the case.
  • Did you write any new necessary tests?

Who can review?

@tgaddair

Copy link
Contributor

@tgaddair tgaddair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! This is definitely an oversight when we introduced the _get_bucket_and_model_id helper.

CI is failing due to a Rust dep, which is a known issue, so I'll land this as is for now.

@tgaddair tgaddair merged commit 87412e1 into predibase:main Feb 10, 2024
1 check failed
@llama-shepard llama-shepard mentioned this pull request Feb 11, 2024
4 tasks
@llama-shepard llama-shepard deleted the fix-S3-adapter-load branch May 16, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants