Upgrading rust for dependency changes #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tgaddair I think I'll need help testing this change. Could you try building the docker image with this change? Thanks a lot! |
magdyksaleh
approved these changes
Feb 14, 2024
|
I kicked off a test build to confirm. It will take some time to complete but the rust portion seems to have run successfully |
|
Sounds good, I'll wait for the test build confirmation from you before merging this. How long does it typically take to wrap up? |
|
I think we are good to merge |
|
@magdyksaleh can you merge the PR for me? I don't have write access and can't technically complete the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrading rust to 1.74 to successfully build docker image.
Before submitting
to it if that's the case.
Who can review?
@tgaddair @jeffreyftang @magdyksaleh