enh: Propagate bearer token from header if one exists for OpenAI-compatible endpoints #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreyftang
changed the title
tgaddair
reviewed
Feb 24, 2024
router/src/server.rs
Outdated
| req: Json<CompletionRequest>, | ||
| ) -> Result<Response, (StatusCode, Json<ErrorResponse>)> { | ||
| let req = req.0; | ||
| let mut gen_req = CompatGenerateRequest::from(req); | ||
|
|
||
| // If a bearer token was present in this request, pass the associated token along. | ||
| let _ = headers.get("authorization").map_or((), |x| { |
There was a problem hiding this comment.
We should do this for the generate and generate_stream endpoints as well (if the user did not pass a token explicitly).
tgaddair
approved these changes
Feb 24, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the OpenAI client doesn't include an API token or authentication key as part of the request payload, it's useful to propagate the bearer token from the incoming request headers so that downstream calls can use it to authenticate.
Alternatively, we could support passing such a token more explicitly via an additional header, which the OpenAI client does support. This is more expressive, but would require the user to take more action.