Generate to max_total_tokens during warmup
#286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgaddair
changed the title
max_total_tokens during warmupmax_total_tokens during warmup
jeffreyftang
approved these changes
Feb 28, 2024
| @@ -731,7 +732,11 @@ def warmup(self, batch: FlashCausalLMBatch): | |||
| self.dtype, | |||
| self.device, | |||
| ) | |||
| _, batch = self.generate_token(batch) | |||
|
|
|||
| with tqdm(total=max_new_tokens, desc="Warmup to max_total_tokens") as pbar: | |||
There was a problem hiding this comment.
Nit: could be nice to put the actual value of max_total_tokens in as well.
There was a problem hiding this comment.
Good point, though will require a bit more plumbing. We do show the max new tokens from the progress bar counter, so will leave as is for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #279.
If the user sets
max_total_tokensto a value greater than what the model can support, catch the error during warmup (initialization) rather than at request time. This is important because device-side asserts leave the server in a broken state requiring a reset.