Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disallow early stopping during warmup #290

Merged
merged 1 commit into from
Feb 29, 2024
Merged

fix: Disallow early stopping during warmup #290

merged 1 commit into from
Feb 29, 2024

Conversation

tgaddair
Copy link
Contributor

Fixes issue where instruct models can early stop during warmup resulting in a None batch being returned.

Also increases the default --max-input-length param to decrease default warmup time and support longer contexts by default.

@tgaddair tgaddair merged commit 36a24ba into main Feb 29, 2024
2 checks passed
@tgaddair tgaddair deleted the warmup-stop branch February 29, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant