Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log generated tokens out to file when streaming #309

Merged
merged 21 commits into from
Mar 14, 2024
Merged

Log generated tokens out to file when streaming #309

merged 21 commits into from
Mar 14, 2024

Conversation

magdyksaleh
Copy link
Collaborator

@magdyksaleh magdyksaleh commented Mar 6, 2024 •
edited

This logs some request metadata to file when a streaming request ends. This allows us to better monitor usage and has some predibase uses.

TODO:

  • Make file location an ENV VAR
  • [ ]

noyoshi
noyoshi reviewed Mar 7, 2024
View reviewed changes
router/src/server.rs Outdated Show resolved Hide resolved
@magdyksaleh magdyksaleh requested a review from noyoshi March 7, 2024 21:29
tgaddair
tgaddair reviewed Mar 10, 2024
View reviewed changes
router/src/server.rs Outdated Show resolved Hide resolved
router/src/server.rs Outdated Show resolved Hide resolved
@tgaddair tgaddair mentioned this pull request Mar 11, 2024
Open
4 tasks
tgaddair
tgaddair reviewed Mar 11, 2024
View reviewed changes
router/src/server.rs Outdated Show resolved Hide resolved
tgaddair
tgaddair reviewed Mar 12, 2024
View reviewed changes
router/src/server.rs Outdated Show resolved Hide resolved
tgaddair
tgaddair approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@tgaddair tgaddair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@magdyksaleh magdyksaleh merged commit 431ae61 into main Mar 14, 2024
1 check passed
@magdyksaleh magdyksaleh deleted the stream-log-dump branch March 14, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgaddair tgaddair tgaddair approved these changes

@noyoshi noyoshi Awaiting requested review from noyoshi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@magdyksaleh @tgaddair @noyoshi