Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: checking the base_model_name_or_path of adapter_config and early return if null #431

Merged
merged 1 commit into from
Apr 22, 2024
Merged

fix: checking the base_model_name_or_path of adapter_config and early return if null #431

merged 1 commit into from
Apr 22, 2024

Conversation

thincal
Copy link
Contributor

@thincal thincal commented Apr 21, 2024

What does this PR do?

Fixes #430

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Was this discussed/approved via a Github issue or the discord / slack channel? Please add a link
    to it if that's the case.
  • Did you write any new necessary tests?

Who can review?

@tgaddair

tgaddair
tgaddair approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@tgaddair tgaddair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@tgaddair tgaddair merged commit 4acc821 into predibase:main Apr 22, 2024
1 check failed
@thincal thincal deleted the fix/handle-null-base_model_name_or_path branch April 22, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgaddair tgaddair tgaddair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

10s latency of lora inference caused by None base_model_name_or_path in adapter_config
2 participants
@thincal @tgaddair