Add support for paged attention v2 and update flash attention v2 #54
+127
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flozi00
reviewed
Nov 22, 2023
Comment on lines
30
to
31
| from lorax_server.utils.flash_attn import attention | ||
| from lorax_server.utils import paged_attn |
There was a problem hiding this comment.
simple design question: why not using flash_attn prefix as with paged_attn
so it would be easier to understand that flash attention is used
if its only attention there could be missunderstandings which one it is
There was a problem hiding this comment.
Good point! I'll update so it will be called as flash_attn.attention instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.