Add DISABLE_SGMV env var to explicitly fallback to loop #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
flozi00
approved these changes
Nov 27, 2023
| @@ -20,7 +20,7 @@ | |||
|
|
|||
| try: | |||
| from lorax_server.utils.sgmv import add_lora_sgmv_cutlass | |||
| HAS_SGMV = True | |||
| HAS_SGMV = not bool(os.environ.get("DISABLE_SGMV", "")) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SGMV kernel is still somewhat experimental. There are some cases (particular ranks, etc.) that can result in erroneous output. Until these issues are fully resolved, this escape hatch will allow users to fallback to the slower but correct loop implementation.
Example: