Updated to custom SGMV kernel to fix issue with certain ranks #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing cutlass based SGMV kernel produces erroneous output for certain LoRA ranks (ex: 32). More recent versions of Punica have introduced a custom shrink kernel that resolves the issue, but only supports ranks [16, 128]. As such, we introduce logic in this PR to use the custom kernel when the rank falls within the valid range, otherwise fallback to the legacy kernel (which does work for rank 8, but may not work for other ranks, need additional testing).
Example:
Compared with transformers:
Output:
Updated vendored Kernels to punica-ai/punica@87cb9f5
Related: #68.