-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 formatting + linting in CI-CD #143
Conversation
Codecov Report
@@ Coverage Diff @@
## main #143 +/- ##
==========================================
- Coverage 97.49% 97.08% -0.41%
==========================================
Files 11 12 +1
Lines 878 892 +14
==========================================
+ Hits 856 866 +10
- Misses 22 26 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Seems good! Some questions:
When I get these answers, I will continue my review. |
To run locally, just perform Once all (new) dev dependencies are installed, you can use the
-> I updated the CONTRIBUTING.md with how you should run the formatting & linting (& testing) locally Hope this answers your questions @jonasvdd |
Does the |
This PR adds the following CI-CD checks:
🤖 added a
Makefile
to, uhm, make it more convenient to call the lint & formatting commandsmake lint
make lint