Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ making flask_cors & kaleido optional #177

Merged
merged 7 commits into from
Mar 8, 2023
Merged

✨ making flask_cors & kaleido optional #177

merged 7 commits into from
Mar 8, 2023

Conversation

jvdd
Copy link
Member

@jvdd jvdd commented Mar 8, 2023

Closes #125

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2023

Codecov Report

Merging #177 (b52a3c0) into main (80f8a06) will decrease coverage by 0.21%.
The diff coverage is 72.72%.

❗ Current head b52a3c0 differs from pull request most recent head 7fbbc35. Consider uploading reports for the commit 7fbbc35 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
- Coverage   97.31%   97.11%   -0.21%     
==========================================
  Files          12       12              
  Lines         894      900       +6     
==========================================
+ Hits          870      874       +4     
- Misses         24       26       +2     
Impacted Files Coverage Δ
...tly_resampler/figure_resampler/figure_resampler.py 89.16% <72.72%> (-1.19%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jvdd jvdd changed the title ✨ making flask_cors optional ✨ making flask_cors & kaleido optional Mar 8, 2023
@jvdd
Copy link
Member Author

jvdd commented Mar 8, 2023

Poetry picks 0.2.1.post1 for kaleido, however this version is only for arm32 - plotly/Kaleido#156

Locking kaleido to 0.2.1 until a new version is released (which is imo totally fine as it is now just an optionally dependency)

@jvdd jvdd merged commit a0c8db6 into main Mar 8, 2023
@jvdd jvdd deleted the prune_deps branch March 21, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make kaleido & flask-cors optional depedencies
3 participants