Fixes #210 #211
Merged
Fixes #210 #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasvdd
commented
May 11, 2023
plotly_resampler/figure_resampler/figure_resampler_interface.py
Outdated
Show resolved
Hide resolved
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #211 +/- ##
=======================================
Coverage 97.15% 97.15%
=======================================
Files 13 13
Lines 983 985 +2
=======================================
+ Hits 955 957 +2
Misses 28 28
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jonasvdd
added a commit
that referenced
this pull request
May 14, 2023
* 🍌 formatting * 💨 first version of log axis support * 🙈 fix tests * 🔧 adresses #190 and #205 * 🙈 formatting * Datetime bugfix (#209) * 💪 add tests for #208 * 🙏 fix for #208 * Fixes #210 (#211) * 💪 add tests for #208 * 🙏 fix for #208 * ✨ tests for #210 * 💪 code-fix for #210 * 🔧 tests for setting hf_x dynamically for #210 * 🔥 fix for setting hf_series x to a tz-aware pd.Series * 🖊️ review * 🔍 review code * 🔍 fix helper method * 🙏 --------- Co-authored-by: jvdd <boebievdd@gmail.com> * 🔍 review * 🖊️ review code * ✨ improve docs + add rangeindex log test * 💨 fix test + add example * 🔍 review code --------- Co-authored-by: jvdd <boebievdd@gmail.com> Co-authored-by: Jeroen Van Der Donckt <18898740+jvdd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #210