Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datetime range #213

Merged
merged 3 commits into from
May 15, 2023
Merged

Datetime range #213

merged 3 commits into from
May 15, 2023

Conversation

jonasvdd
Copy link
Member

Fixes #212

@jonasvdd
Copy link
Member Author

Ready for review @jvdd

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2023

Codecov Report

Merging #213 (a48072f) into main (4157229) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #213   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files          13       13           
  Lines         989      989           
=======================================
  Hits          961      961           
  Misses         28       28           
Impacted Files Coverage Δ
..._resampler/aggregation/plotly_aggregator_parser.py 94.56% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jvdd jvdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Once again, nice fix @jonasvdd

@jvdd
Copy link
Member

jvdd commented May 15, 2023

I'll create a new rc once this is merged!

@jonasvdd jonasvdd merged commit ef0d4e9 into main May 15, 2023
14 of 16 checks passed
@jonasvdd
Copy link
Member Author

nice review, the code is merged!

@jvdd jvdd deleted the datetime_range branch June 18, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting an AttributeError from a timezone labeled time series
3 participants