Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃懛 build: create codeql.yml #248

Merged
merged 3 commits into from
Jul 24, 2023
Merged

馃懛 build: create codeql.yml #248

merged 3 commits into from
Jul 24, 2023

Conversation

NielsPraet
Copy link
Collaborator

Adds github code scanning to the repository.

@jonasvdd
Copy link
Member

@NielsPraet good work!

Maybe you can also add the CI filter that the unit tests only runs when there are new changes are made to the:

  • tests directory
  • plotly_resampler directory
  • poetry.lock

@jvdd - please correct me when I'm missing something!

@jonasvdd jonasvdd requested a review from jvdd July 24, 2023 10:15
@jonasvdd jonasvdd self-assigned this Jul 24, 2023
@jonasvdd jonasvdd added the enhancement New feature or request label Jul 24, 2023
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@jonasvdd
Copy link
Member

resolves #157

@jvdd
Copy link
Member

jvdd commented Jul 24, 2023

Perhaps also poetry.toml and the Makefile @jonasvdd?

@jonasvdd
Copy link
Member

@jvdd, why the poetry.toml and the makefile?

The poetry.lock should be directly affected by the pyproject.toml right?
When looking at the test.yml It appears that the makefile is not utilized by the tesing?

@jvdd
Copy link
Member

jvdd commented Jul 24, 2023

Skip the Makefile - the poetry.toml might however be conflicting with the poetry.lock (when not used correctly).

Only run tests when changes are made to:
  - tests/
  - plotly_resampler/
  - poetry.lock
@jonasvdd
Copy link
Member

nice! :)

@jonasvdd
Copy link
Member

LGTM! :)

@jvdd jvdd merged commit 7c3bc80 into main Jul 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants