Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rangeslider support #254

Merged
merged 34 commits into from
Nov 1, 2023
Merged

Rangeslider support #254

merged 34 commits into from
Nov 1, 2023

Conversation

jonasvdd
Copy link
Member

@jonasvdd jonasvdd commented Aug 25, 2023

This is a first draft of cleaned version of rangeslider support:

Still to do:

  • improve UI (less clear rangeslider)
  • create examples
  • add rangeslider to example notebook
  • write tests
  • add docs
  • add argument to specify rangeslider layout
  • [x ] verify rendered docs
  • add example gifs (to example notebook / readme / documentation)

How it looks now
Peek 2023-10-25 01-51

@ISX2
Copy link

ISX2 commented Aug 28, 2023

Add example result gifs!
See: ad17cfd

😁

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

Merging #254 (c4181ff) into main (574904e) will decrease coverage by 0.34%.
Report is 4 commits behind head on main.
The diff coverage is 92.79%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
- Coverage   96.87%   96.53%   -0.34%     
==========================================
  Files          14       14              
  Lines        1024     1127     +103     
==========================================
+ Hits          992     1088      +96     
- Misses         32       39       +7     
Files Coverage Δ
plotly_resampler/__init__.py 84.61% <100.00%> (ø)
plotly_resampler/figure_resampler/__init__.py 100.00% <100.00%> (ø)
...tly_resampler/figure_resampler/figure_resampler.py 90.47% <92.66%> (+2.62%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jonasvdd jonasvdd requested a review from jvdd October 23, 2023 00:50
@jonasvdd jonasvdd added the enhancement New feature or request label Oct 23, 2023
@jonasvdd
Copy link
Member Author

Ready for review @jvdd!

Copy link
Member

@jvdd jvdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Amazing work mate 🦘 🤝

@jonasvdd jonasvdd merged commit b117121 into main Nov 1, 2023
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants