-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌾 figurewidget support #47
Conversation
Codecov Report
@@ Coverage Diff @@
## main #47 +/- ##
==========================================
+ Coverage 98.03% 98.20% +0.17%
==========================================
Files 6 9 +3
Lines 457 556 +99
==========================================
+ Hits 448 546 +98
- Misses 9 10 +1
Continue to review full report at Codecov.
|
Read for review @jvdd! |
plotly_resampler/figure_resampler/figure_resampler_interface.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just check my 3 comments above
Amazing functionality improvements 🔥
TODOs:
FigureWidgetResampler
FigureWidgetResampler
To decide:
Not a fan of this -> will break backward code compatibility (
mode="inline"
argument not available within jupyter)Not a fan of this -> will make it a little too complex to document/explain?
If we would do this, we could opt to just make 1 big class which serves all functionality.