Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌾 figurewidget support #47

Merged
merged 19 commits into from
May 6, 2022
Merged

🌾 figurewidget support #47

merged 19 commits into from
May 6, 2022

Conversation

jonasvdd
Copy link
Member

@jonasvdd jonasvdd commented Apr 30, 2022

TODOs:

  • add documentation of FigureWidgetResampler
  • update the Readme / getting_started.rst
  • add tests for FigureWidgetResampler
    • 2x Autorange / 2x autoscale
    • check whether fig.show() works (with and without config)
      • Does not work -> returns a static figure -> should be documented
  • create new major release & shill 🔥

To decide:

  • ❌ Jupyterdash -> dash? (and an optional dash dependency?)
    Not a fan of this -> will break backward code compatibility (mode="inline" argument not available within jupyter)
  • ❌ Support show-dash for figurewidgets or not? (why does(n't) it make sense to do this?
    Not a fan of this -> will make it a little too complex to document/explain?
    If we would do this, we could opt to just make 1 big class which serves all functionality.

@jonasvdd jonasvdd mentioned this pull request Apr 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2022

Codecov Report

Merging #47 (10cb22a) into main (08fa9a5) will increase coverage by 0.17%.
The diff coverage is 95.68%.

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   98.03%   98.20%   +0.17%     
==========================================
  Files           6        9       +3     
  Lines         457      556      +99     
==========================================
+ Hits          448      546      +98     
- Misses          9       10       +1     
Impacted Files Coverage Δ
...tly_resampler/figure_resampler/figure_resampler.py 88.09% <88.09%> (ø)
...sampler/figure_resampler/figurewidget_resampler.py 98.70% <98.70%> (ø)
plotly_resampler/__init__.py 100.00% <100.00%> (ø)
plotly_resampler/figure_resampler/__init__.py 100.00% <100.00%> (ø)
...ler/figure_resampler/figure_resampler_interface.py 99.21% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08fa9a5...10cb22a. Read the comment docs.

@jonasvdd jonasvdd marked this pull request as ready for review May 3, 2022 19:53
@jonasvdd jonasvdd requested a review from jvdd May 4, 2022 15:52
@jonasvdd
Copy link
Member Author

jonasvdd commented May 5, 2022

Read for review @jvdd!

Copy link
Member

@jvdd jvdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just check my 3 comments above

Amazing functionality improvements 🔥

@jonasvdd jonasvdd merged commit 1e80f4e into main May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants