Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🦌 Adding reset-axes functionality #48

Merged
merged 8 commits into from
May 8, 2022
Merged

🦌 Adding reset-axes functionality #48

merged 8 commits into from
May 8, 2022

Conversation

jonasvdd
Copy link
Member

@jonasvdd jonasvdd commented May 7, 2022

This pr introduces the FigureWidgetResampler.reset_axes method, which allows performing a reset_axes after adjusting the hf_data properties of the FigureWidgetResampler instance.

Should resolve #45

TODO:

  • Add tests
  • Document this behavior

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2022

Codecov Report

Merging #48 (47f1801) into main (61f46fe) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   98.20%   98.23%   +0.02%     
==========================================
  Files           9        9              
  Lines         556      565       +9     
==========================================
+ Hits          546      555       +9     
  Misses         10       10              
Impacted Files Coverage Δ
...sampler/figure_resampler/figurewidget_resampler.py 98.83% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f46fe...47f1801. Read the comment docs.

@jonasvdd
Copy link
Member Author

jonasvdd commented May 8, 2022

LGTM! :)

@jonasvdd jonasvdd merged commit 3d8f6af into main May 8, 2022
@jvdd jvdd deleted the reset_axes branch June 18, 2022 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FigureWidget() update
3 participants