-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix numeric hf_y
input as dtype object
#90
Conversation
Codecov Report
@@ Coverage Diff @@
## main #90 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 10 10
Lines 745 746 +1
=======================================
+ Hits 731 732 +1
Misses 14 14
Continue to review full report at Codecov.
|
Hmmm not really keen on this implementation. When you have data type object that contains bools it gets now converted to float as well (which is not in line with the plotly behavior). fig = go.Figure()
fig.add_trace(
go.Scattergl(
y=np.array([True, False]*20).astype(object),
mode="markers"
)
)
# This shows true & false on the y-axis fig = FigureWidgetResampler()
fig.add_trace(
go.Scattergl(
mode="markers"
),
hf_y = np.array([True, False]*20).astype(object)
)
# This shows 0 & 1 on the y-axis |
Maybe first try parsing to bool? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Added some extra tests for binary data (to check if it does not get transformed to bool)
Should fix #89
TODO: