Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 add support for figure dict input + propagate _grid_str #92

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

jvdd
Copy link
Member

@jvdd jvdd commented Jun 30, 2022

This PR does;

  • support figure as a dict as input for our wrappers (e.g. FigureResampler(fig.to_dict()) with fig a go.Figure)
    => this is in line with the vanilla plotly behavior (see BaseFigure constructor documentation)
  • propagate _grid_str in our composable constructors
  • test the above

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2022

Codecov Report

Merging #92 (862bc0a) into main (2ed7423) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   98.12%   98.15%   +0.03%     
==========================================
  Files          10       10              
  Lines         746      759      +13     
==========================================
+ Hits          732      745      +13     
  Misses         14       14              
Impacted Files Coverage Δ
...tly_resampler/figure_resampler/figure_resampler.py 90.90% <100.00%> (+0.90%) ⬆️
...ler/figure_resampler/figure_resampler_interface.py 99.70% <100.00%> (+<0.01%) ⬆️
...sampler/figure_resampler/figurewidget_resampler.py 99.00% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ed7423...862bc0a. Read the comment docs.

@jvdd jvdd changed the base branch from main to os_matrix June 30, 2022 21:40
@jvdd jvdd changed the base branch from os_matrix to main June 30, 2022 21:41
@jvdd jvdd changed the base branch from main to os_matrix June 30, 2022 21:43
@jvdd jvdd merged commit 1c2f571 into os_matrix Jun 30, 2022
@jonasvdd jonasvdd deleted the figure_dict_input branch July 29, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants