🔍 add searchsorted to get equidistant x-bins #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvdd
commented
Dec 24, 2022
Comment on lines
-4
to
-6
| // TODO | ||
| // - m4 & minmax should determine bin size on x-range! | ||
| // code now assumes equal bin size |
There was a problem hiding this comment.
Extremely happy to tick this one off 🔥
jvdd
commented
Dec 24, 2022
| @@ -157,13 +153,13 @@ macro_rules! create_pyfuncs_without_x_with_ratio { | |||
|
|
|||
| macro_rules! create_pyfuncs_with_x { | |||
| ($resample_mod:ident, $resample_fn:ident, $mod:ident) => { | |||
| _create_pyfuncs_with_x_generic!(_create_pyfunc_with_x, $resample_mod, $resample_fn, $mod, f16 f32 f64 i16 i32 i64 u16 u32 u64, f16 f32 f64 i8 i16 i32 i64 u8 u16 u32 u64); | |||
There was a problem hiding this comment.
Removed f16 support as this (i) does not make sense IMO as x-data type (for this library which focuses on resampling very large time series) and (ii) is probably (haven't tested this) a lot slower than the other datatypes bc equidistant binning not (yet) adapted to f16 (which is not supported by most CPUs)
jvdd
commented
Dec 24, 2022
| }; | ||
| } | ||
|
|
||
| macro_rules! create_pyfuncs_with_x_with_ratio { | ||
| ($resample_mod:ident, $resample_fn:ident, $mod:ident) => { | ||
| _create_pyfuncs_with_x_generic!(_create_pyfunc_with_x_with_ratio, $resample_mod, $resample_fn, $mod, f16 f32 f64 i16 i32 i64 u16 u32 u64, f16 f32 f64 i8 i16 i32 i64 u8 u16 u32 u64); |
jvdd
commented
Dec 24, 2022
jvdd
commented
Dec 25, 2022
jvdd
commented
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR alleviates the assumption that when
xhas fixed sampling rate (& no gaps) for certain downsample algorithms.Should fix #10.
This PR has the following contributions:
utils.rsval_stepas this avoids rounding errors with integer / usize x-data types!! => seems to be significantly slower for minmaxlttb (10 - 20 %)
xxx?n_outrequirements etc.)genericcode of the downsample algorithmsAlgorithm changes:
=> when
arr.len%n_out= 0 & equally sampled (+ no gaps) => difference betweeen with x and without x implementation=> when
arr.len%n_out= 0 & equally sampled (+ no gaps) => difference betweeen with x and without x implementationPython binding changes:
f16as supportedxdatatype (IMO, no 16-bit dtypes make sense asxdatatype... as these at max (u16) can only represent up to 65_535 values)n_outto be multiple of 4n_outto be multiple of 2