This repository has been archived by the owner on Feb 17, 2021. It is now read-only.
Add stubs for to_pickle and read_pickle #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So it seems the tests for python 3.9 are downloading a newer version of pandas (1.2) which has the problem mentioned in #215. Is it easy to fix that? |
|
I'm actually a bit surprised that pandas already dropped python 3.6 support. |
|
I guess a workaround would be to use the previous version in the tests by updating .github/workflows/test_correctness.yml to install I'm not really clear enough on |
|
Okay, then let's do this for now
You can just edit the file. |
Pandas 1.2 changes iloc behaviour resulting in errors for current implementation of test_frame_iloc. As a workaround restict the version of Pandas when running tests.
EdwardJRoss
force-pushed
the
add_to_pickle
branch
from
43261b9
to
6cb588b
Compare
|
Great, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #216