Run tests under PHP 8.3 (#1396)

predis · Oct 25, 2023 · d44f073 · d44f073
1 parent a9d18b1
commit d44f073
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/.github/workflows/stack.yml b/.github/workflows/stack.yml
@@ -30,9 +30,12 @@ jobs:
           - '8.0'
           - '8.1'
           - '8.2'
+          - '8.3'
         redis:
           - latest
 
+    continue-on-error: ${{ matrix.php == '8.3' }}
+
     steps:
       - name: Checkout
         uses: actions/checkout@v3

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -27,6 +27,7 @@ jobs:
           - '8.0'
           - '8.1'
           - '8.2'
+          - '8.3'
         redis:
           - 3
           - 4
@@ -98,6 +99,7 @@ jobs:
           - '8.0'
           - '8.1'
           - '8.2'
+          - '8.3'
 
     steps:
       - name: Checkout repository

diff --git a/composer.json b/composer.json
@@ -27,7 +27,7 @@
     "require-dev": {
         "friendsofphp/php-cs-fixer": "^3.3",
         "phpstan/phpstan": "^1.9",
-        "phpunit/phpunit": "^8.0 || ~9.4.4"
+        "phpunit/phpunit": "^8.0 || ^9.4"
     },
     "suggest": {
         "ext-relay": "Faster connection with in-memory caching (>=0.6.2)"

diff --git a/src/Connection/Cluster/RedisCluster.php b/src/Connection/Cluster/RedisCluster.php
@@ -258,7 +258,7 @@ private function queryClusterNodeForSlotMap(NodeConnectionInterface $connection)
                 }
 
                 usleep($retryAfter * 1000);
-                $retryAfter = $retryAfter * 2;
+                $retryAfter *= 2;
                 ++$retries;
             }
         }
@@ -541,7 +541,7 @@ private function retryCommandOnFailure(CommandInterface $command, $method)
                 break;
             } catch (Throwable $exception) {
                 usleep($retryAfter * 1000);
-                $retryAfter = $retryAfter * 2;
+                $retryAfter *= 2;
 
                 if ($exception instanceof ConnectionException) {
                     $connection = $exception->getConnection();