Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SORT method with parameter GET don't work #1

Closed
roccogalluzzo opened this issue Feb 11, 2010 · 1 comment
Closed

SORT method with parameter GET don't work #1

roccogalluzzo opened this issue Feb 11, 2010 · 1 comment
Labels

Comments

@roccogalluzzo
Copy link

Hi
when try to execute the code below the result is an array with empty values (keys are present). if delete the get parameter the command work corretly.
$res=$r->sort('key',array(
'get'=>array('otherkey:*'),
'limit'=>array(10,20)));
PS: With redis-cli the same command work.

@nrk
Copy link
Contributor

nrk commented Feb 11, 2010

Thanks for the report.

I'm closing this particular issue as a non-bug due to the fact that the GET parameter for LIMIT expects a string value and not an array, so if you pass "otherkey:" instead of array("otherkey:") everything works fine and you get the actual values in the response.

That being said, it would be indeed useful to have LIMIT ... GET accepting also an array of keys given that the Redis docs explicitly state that: "Note that GET can be used multiple times in order to get more keys for every element of the original List, Set or Sorted Set sorted.". I'm taking this as a feature request.

emporium-nsalter added a commit to webteam-eandl/predis that referenced this issue Nov 16, 2018
…o v1.1

* commit '5ae68665a195191c5e0cc0d70d4a3c07a69f24ab':
  Fix test error message
  Replacing each with php7.2 compatible replacement
  Update phpunit to use test redis server
tillkruss added a commit that referenced this issue May 7, 2022
* - init 8.1 tests
- adding `#[\ReturnTypeWillChange]`
- Fix deprecation message: strlen(): Passing null to parameter #1 ($string) of type string is deprecated
- null is not allowed
- cleanup
- default values should be same type

* Mirror `v1.1` fixes for these files

* add null as type too since we also accept null as default value

Signed-off-by: Zaher Ghaibeh <zaher@zaher.dev>

* revert back to assertNull

* Update CHANGELOG

* Update CHANGELOG.md

Co-authored-by: Till Krüss <tillkruss@users.noreply.github.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants