Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Del/Delete command should return the count of deleted keys #4

Closed
cysin opened this issue May 7, 2010 · 1 comment
Closed

Del/Delete command should return the count of deleted keys #4

cysin opened this issue May 7, 2010 · 1 comment
Labels
bug

Comments

@cysin
Copy link

cysin commented May 7, 2010

Del/Delete command should return the count of deleted keys, but I noticed that in Predis the return value was converted to bool type. Wouldn't it be better to make it return the actual number deleted?
@nrk
Copy link
Contributor

nrk commented May 10, 2010

That was actually an oversight on my side, I have fixed this issue in the current development version. Thanks for reporting this bug!

@mikemccabe mikemccabe mentioned this issue Feb 10, 2012
Closed
Closed
@rookie7799 rookie7799 mentioned this issue Apr 16, 2012
Closed
@starinacool starinacool mentioned this issue May 29, 2013
Closed
@vSaKv vSaKv mentioned this issue May 29, 2013
Closed
@R-Ong R-Ong mentioned this issue Jun 24, 2013
Closed
@chrom chrom mentioned this issue Jan 9, 2014
Closed
@1merlin1 1merlin1 mentioned this issue Aug 25, 2014
Closed
@ltanme ltanme mentioned this issue Dec 30, 2015
Closed
@yuchao86 yuchao86 mentioned this issue Jun 27, 2016
Closed
@ankushktr ankushktr mentioned this issue Mar 4, 2018
Closed
@xiaobaig0407 xiaobaig0407 mentioned this issue Aug 30, 2018
Closed
@googleshokry googleshokry mentioned this issue Nov 2, 2022
Closed
@TimoFrenzel TimoFrenzel mentioned this issue Nov 15, 2022
Closed
vladvildanov added a commit that referenced this issue Nov 1, 2023
@vladvildanov @chayim
Added support for redis gears trigger function commands (#1348)
662fdb9 
* Added support for redis gears trigger function commands

* Exclude gears tests from relay connection tests

* Codestyle fixes

* Added missing test coverage

* Updated method description

* Use redis-stack:edge image istead of separate container

* Updated RESP3 modules responses

* Removed redundant constants

* Added additional timeout to make sure that index was created

* Marked test as relay-incompatible

* Mark tests as relay-incompatible

* Mark tests as relay-incompatible

* Increase timeout after index creation

* Added support for trigger functions command run against OSS cluster

* Mark gears cluster tests with appropriate annotation

* Marked with cluster annotation

* Codestyle fixes

* Removed refresh cluster on connection, moved to refresh manually in tests

* Removed redundant test

* Updated README, added comments with README references

* Revert "Marked test as relay-incompatible"

This reverts commit d888968.

* Revert changes

* Revert "Mark tests as relay-incompatible"

This reverts commit 7d34370.

* Revert "Updated RESP3 modules responses"

This reverts commit 5cf122a.

* Removed latest image

* Updated RESP3 modules responses (#4)

* Marked tests as relay-incompatible (#3)

* Marked test as relay-incompatible

* Mark tests as relay-incompatible

* Mark tests as relay-incompatible

* Changed tests group for RESP3 not supported tests

* Fixed broken tests

* Removed redundant test

* Marked test as relay-incompatible

* Codestyle fixes

* Updated CHANGELOG.md

* Updated CHANGELOG.md

* Revert php-cs-fixer style changes

---------

Co-authored-by: Chayim <chayim@users.noreply.github.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nrk @cysin