[v3.x] Fix prefix error if prefix equals a php command #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tillkruss Now tests are passing, only code style test failing but has nothing to do with my change? |
tillkruss
reviewed
Sep 18, 2023
|
See #1329. |
tillkruss
requested changes
Sep 22, 2023
| @@ -28,7 +29,7 @@ class Prefix implements OptionInterface | |||
| */ | |||
| public function filter(OptionsInterface $options, $value) | |||
| { | |||
| if (is_callable($value)) { | |||
| if (is_callable($value) && ! function_exists($value)) { | |||
There was a problem hiding this comment.
@mmodler Great, let's add a new test case that "chr" won't be called as a function and we can merge it.
|
@vladvildanov Should we move this into v3? |
tillkruss
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix php error if prefix equals a php command like "chr" for example.
Replaced is_callable with instanceof Closure, which should preserve the desired behavior.
Hopefully better fix for #1339