Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Relay integration #1423

Merged
merged 6 commits into from
Dec 28, 2023
Merged

Improved Relay integration #1423

merged 6 commits into from
Dec 28, 2023

Conversation

vladvildanov
Copy link
Contributor

@vladvildanov vladvildanov commented Dec 26, 2023

See #1292.

* Fixed Relay objects structure

* Mark test as relay-incompatible, relay sets it's own name

* Codestyle fixes

* Removed ignoring for non existing error
* Added OSS cluster test

* Added additional PHP version requirement

* Codestyle typo
@vladvildanov
Copy link
Contributor Author

@tillkruss Lmk if there's anything else we need to improve

@coveralls
Copy link

coveralls commented Dec 26, 2023

Coverage Status

coverage: 92.422% (-0.3%) from 92.742%
when pulling 57366ae on feature/relay-improvements
into 87b0d2f on v3.x.

src/Connection/RelayFactory.php Show resolved Hide resolved
src/Connection/RelayFactory.php Show resolved Hide resolved
@tillkruss
Copy link
Member

@vladvildanov This needs a rebase when you have a moment.

@tillkruss tillkruss mentioned this pull request Dec 27, 2023
8 tasks
@tillkruss tillkruss added client-cluster Cluster (client-side sharding) breakingchange relay labels Dec 27, 2023
@tillkruss tillkruss self-assigned this Dec 28, 2023
@tillkruss tillkruss merged commit d56e327 into v3.x Dec 28, 2023
42 checks passed
@tillkruss tillkruss deleted the feature/relay-improvements branch December 28, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants