New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit version of php-cs-fixer >= 3.4.0 <= 3.5.0 #1445
Open
vladvildanov
wants to merge
5
commits into
predis:v2.x
Choose a base branch
from
vladvildanov:vv-2.x-limit-php-fixer-version
base: v2.x
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Limit version of php-cs-fixer >= 3.4.0 <= 3.5.0 #1445
vladvildanov
wants to merge
5
commits into
predis:v2.x
from
vladvildanov:vv-2.x-limit-php-fixer-version
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohorev
reviewed
Mar 21, 2024
Co-authored-by: Alexander Mohorev <dev.mohorev@gmail.com>
tillkruss
reviewed
Mar 22, 2024
@@ -25,7 +25,7 @@ | |||
"php": "^7.2 || ^8.0" | |||
}, | |||
"require-dev": { | |||
"friendsofphp/php-cs-fixer": "^3.3", | |||
"friendsofphp/php-cs-fixer": "~3.4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should lock the version of php-cs-fixer
, maybe we just adjust the rules and code as they update?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Php-cs-fixer package continue constantly updating, so are codestyle rules. This leads often to CI failures and requires separate PR so it won't be mixed with actual changes. I propose to limit to the latest minor version, to avoid this codestyle changes and lately we have to choose more stable version.