update sort command to be a write operation #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build appears to fail because travis is using redis-server with version 4.0.x, which has a different error message than expected when selecting a DB out of range |
nrk
added
bug
client-replication
|
Thank you! Fixes will be included with Predis v1.1.4 when it's released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #468
As noted in the linked issue, Redis treats all SORT commands as 'write' operations
https://github.com/antirez/redis/blob/4.0/src/server.c#L252
This patch removes 'SORT' from the array returned by ReplicationStrategy::getReadOnlyOperations() and removes the isSortReadOnly() helper method. Related tests were also updated.