Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

US159759: Keti: Change package names to use org.eclipse.keti #189

Closed
wants to merge 1 commit into from
Closed

US159759: Keti: Change package names to use org.eclipse.keti #189

wants to merge 1 commit into from

Conversation

VoollaSandeepKumar
Copy link
Contributor

US159759: Keti: Change package names to use org.eclipse.keti

sebastiantb
sebastiantb reviewed Jan 11, 2018
View reviewed changes
Copy link
Contributor

@sebastiantb sebastiantb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+import org.eclipse.keti.acs.model.
+import org.eclipse.keti.acs.service
+import org.eclipse.keti.acs.commons
ACS sub package needs to be removed, project is not acs anymore.
refactor to:
+import org.eclipse.keti.model.
+import org.eclipse.keti.service
+import org.eclipse.keti.commons

sebastiantb
sebastiantb suggested changes Jan 11, 2018
View reviewed changes
Copy link
Contributor

@sebastiantb sebastiantb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+import org.eclipse.keti.acs.model.
+import org.eclipse.keti.acs.service
+import org.eclipse.keti.acs.commons
ACS sub package needs to be removed, project is not acs anymore.
refactor to:
+import org.eclipse.keti.model.
+import org.eclipse.keti.service
+import org.eclipse.keti.commons

@anubhavi25
Copy link
Contributor

@VoollaSandeepKumar closing this since changes should be applied directly to a branch checked out from master on https://github.com/eclipse/keti

@anubhavi25 anubhavi25 closed this Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastiantb sebastiantb sebastiantb requested changes

@anubhavi25 anubhavi25 Awaiting requested review from anubhavi25

@irinaepshteyn irinaepshteyn Awaiting requested review from irinaepshteyn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@VoollaSandeepKumar @anubhavi25 @sebastiantb