Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAX-10493 Add hover color for trigger icon #3

Merged
merged 1 commit into from Dec 8, 2018

Conversation

benjaminliugang
Copy link
Contributor

Added focus color for trigger icon.

@evanjd evanjd self-requested a review December 8, 2018 08:18
Copy link
Contributor

@evanjd evanjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Please remove your changes the HISTORY.md and package.json - we'll update this for you when a change is merged.

Also, it looks like your commits have been made with an e-mail not linked with your github account - this is why the CLA check is failing. Please rebase and update your commit e-mail to match what's on your profile.

HISTORY.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@cla-bot
Copy link

cla-bot bot commented Dec 8, 2018

Thank you for your pull request. We require contributors to sign our Contributor License Agreement here.

@evanjd
Copy link
Contributor

evanjd commented Dec 8, 2018

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Dec 8, 2018

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot cla-bot bot added the cla-signed label Dec 8, 2018
@benjaminliugang
Copy link
Contributor Author

@evanjd How can I check the failed reason for The Travis CI build failed?

@evanjd
Copy link
Contributor

evanjd commented Dec 8, 2018

@benjaminliugang Click the Details link for the build log. The build failure isn't from your changes so you don't need to worry about fixing anything.

I'm working on the broken tests now, will merge the fixed tests into your branch ASAP.

@evanjd
Copy link
Contributor

evanjd commented Dec 8, 2018

Tests fixed on master, merging.

@evanjd evanjd merged commit 46eadfe into predixdesignsystem:master Dec 8, 2018
@evanjd
Copy link
Contributor

evanjd commented Dec 8, 2018

v1.0.11 released with your change.

@benjaminliugang
Copy link
Contributor Author

@evanjd , Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants