Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitle description and dimension update #1

Conversation

neovichsu
Copy link
Contributor

@neovichsu neovichsu commented Nov 21, 2017

Add subtitle, description and dimension update

  • Adding subtitles and description onto px tile based on new px tile design
  • Apply truncation on subtitle (single line) and description (can be specified by number of lines)
  • Descriptions are now broken into two separate properties to allow use case in which the description text can be different from overlay description text.
  • Apply new px tile layout design
  • Add more px tile scss variables so developers can customize such as text color, multi-line truncation(ellipsis), height of description text, and height of overlay description text.
  • New px tile color theme variables values will be added in px-theme as a separate PR.

Reviewers:
@mdwragg @randyaskin @katemenkhaus @german777

  • working tests: WCT unit tests are added.

@mdwragg
Copy link
Contributor

mdwragg commented Nov 28, 2017

@Lizricharson53 ^^ of interest to you!

@randyaskin randyaskin merged commit dfc8bb2 into predixdesignsystem:master Dec 15, 2017
randyaskin added a commit that referenced this pull request Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants