adding in initial lower-level support for MAS files

[thepeteriley]

No description provided.

[codecov-commenter]

Codecov Report

Merging #101 (68a210f) into main (81d2dd0) will decrease coverage by 12.97%.
The diff coverage is 0.00%.

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #101       +/-   ##
===========================================
- Coverage   87.35%   74.37%   -12.98%     
===========================================
  Files          29       30        +1     
  Lines         957     1124      +167     
===========================================
  Hits          836      836               
- Misses        121      288      +167     

Impacted Files	Coverage Δ
psipy/psihdf/psihdf.py	0.00% <0.00%> (ø)

[dstansby]

Is the goal of this PR to enable users to access the numpy arrays of the data directly? If so, two thoughts:

1. Ideally users should never have to use the raw numpy array, but use it with the grid and unit information attached. That's the reason why I made the classes in the first place! If there's a use case that's driving the need to use a raw array, I'd suggest opening an issue, and working out a way to do what is required through the main classes that exist already.
2. It's should be possible to get the data once it's been loaded into a Variable object through my_variable.data. This returns an xarray.DataArray, and then you can use the .values attribute on that to get the numpy array (so my_variable.data.values in total).

[thepeteriley]

Is the goal of this PR to enable users to access the numpy arrays of the data directly? If so, two thoughts:

1. Ideally users should never have to use the raw numpy array, but use it with the grid and unit information attached. That's the reason why I made the classes in the first place! If there's a use case that's driving the need to use a raw array, I'd suggest opening an issue, and working out a way to do what is required through the main classes that exist already.
2. It's should be possible to get the data once it's been loaded into a Variable object through my_variable.data. This returns an xarray.DataArray, and then you can use the .values attribute on that to get the numpy array (so my_variable.data.values in total).

Yes, this makes sense. I suppose it would have been a convenient way to pack in some lower-level routines into an existing package, but I can appreciate that it would probably make things confusing for the user. It's probably better to package these up into a separate repo, like psipytools (or something catchier?), since they would probably be used for different applications anyway.