Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download + install in add command #202

Closed
jonashaag opened this issue Jul 13, 2023 · 1 comment · Fixed by #213
Closed

Download + install in add command #202

jonashaag opened this issue Jul 13, 2023 · 1 comment · Fixed by #213

Comments

@jonashaag
Copy link

Currently the add command doesn't download + install the package.

Maybe there are good reasons to do it that way but I think I would actually prefer it to be done in the add step. From a UX perspective, I'd rather wait one longer time than two smaller times.

I guess doing the installation in add also opens up some possibilities for reducing the total wall time spent waiting, maybe by doing stuff concurrently.

What's the use case for separating the two? When would you want add to not actually download and install?

@baszalmstra
Copy link
Contributor

I dont see a reason why we shouldnt do that. Ill create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants