Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No path update happening if PIXI_NO_PATH_UPDATE is unset #819

Closed
2 tasks done
markusschlenker opened this issue Feb 19, 2024 · 0 comments · Fixed by #822
Closed
2 tasks done

No path update happening if PIXI_NO_PATH_UPDATE is unset #819

markusschlenker opened this issue Feb 19, 2024 · 0 comments · Fixed by #822
Labels
bug Something isn't working

Comments

@markusschlenker
Copy link

Checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pixi, using pixi --version.

Reproducible example

install.sh

Issue description

In the Linux installer install.sh the new option to suppress PATH update if the env variable PIXI_NO_PATH_UPDATE is set is working inverse of what is expected (at least as I understand it). If PIXI_NO_PATH_UPDATE is unset no PATH update happens. If PIXI_NO_PATH_UPDATE is assigned any value, the PATH update happens.

It appears the ! in the if clause was removed in #737. If I understand correctly, either the ! should be added again or -z be replaced by -n

[[ -n "${PIXI_NO_PATH_UPDATE-}" ]] && return

Expected behavior

If PIXI_NO_PATH_UPDATE is unset the PATH update happens (default). If PIXI_NO_PATH_UPDATE is assigned any value, the PATH update does not happens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant