Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test failure on riscv64 #1045

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

hack3ric
Copy link
Contributor

Those tests' results are affected by unsupported platform error. Adding riscv64 to platforms fixes the issue on it.

Error log:

failures:

---- task::task_graph::test::test_multi_env_defaults_ambigu stdout ----
note: test did not panic as expected
---- task::task_environment::tests::test_find_task_explicit_defined stdout ----
thread 'task::task_environment::tests::test_find_task_explicit_defined' panicked at src/task/task_environment.rs:272:9:
assertion failed: matches!(result, Err(FindTaskError::AmbiguousTask(_)))
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- task::task_environment::tests::test_find_task_dual_defined stdout ----
thread 'task::task_environment::tests::test_find_task_dual_defined' panicked at src/task/task_environment.rs:246:9:
assertion failed: matches!(result, Err(FindTaskError::AmbiguousTask(_)))

---- task::task_environment::tests::test_find_ambiguous_task stdout ----
thread 'task::task_environment::tests::test_find_ambiguous_task' panicked at src/task/task_environment.rs:337:9:
assertion failed: matches!(result, Err(FindTaskError::AmbiguousTask(_)))

---- task::task_graph::test::test_custom_command stdout ----
thread 'task::task_graph::test::test_custom_command' panicked at src/task/task_graph.rs:322:10:
called `Result::unwrap()` on an `Err` value: UnsupportedPlatform(UnsupportedPlatform(UnsupportedPlatformError { environments_platforms: [Linux64, Win64, Osx64, OsxArm64], environment: Default, platform: LinuxRiscv64 }))


failures:
    task::task_environment::tests::test_find_ambiguous_task
    task::task_environment::tests::test_find_task_dual_defined
    task::task_environment::tests::test_find_task_explicit_defined
    task::task_graph::test::test_custom_command
    task::task_graph::test::test_multi_env_defaults_ambigu

test result: FAILED. 125 passed; 5 failed; 0 ignored; 0 measured; 0 filtered out; finished in 24.84s

Those tests' results are affected by unsupported platform error. Adding riscv64 to platforms fixes the issue on it.
hack3ric added a commit to hack3ric/archriscv-packages that referenced this pull request Mar 22, 2024
hack3ric added a commit to hack3ric/archriscv-packages that referenced this pull request Mar 22, 2024
felixonmars pushed a commit to felixonmars/archriscv-packages that referenced this pull request Mar 22, 2024
Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool wasn't aware we had riscv users! Thanks!

@ruben-arts ruben-arts enabled auto-merge (squash) March 25, 2024 07:36
@ruben-arts ruben-arts merged commit 999db88 into prefix-dev:main Mar 25, 2024
23 checks passed
@hack3ric hack3ric deleted the fix-riscv64-tests branch March 25, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants