feat: Allow to upgrade several global packages at once #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivier-lacroix
force-pushed
the
refactorupgrade
branch
from
481cf61
to
d54cdbe
Compare
olivier-lacroix
force-pushed
the
refactorupgrade
branch
from
6f49292
to
99322b8
Compare
olivier-lacroix
force-pushed
the
refactorupgrade
branch
from
99322b8
to
3f08109
Compare
olivier-lacroix
commented
May 5, 2024
| } | ||
|
|
||
| // Remove possible duplicates | ||
| channels = channels.into_iter().unique().collect::<Vec<_>>(); |
There was a problem hiding this comment.
I note channels is common across all global packages. Is this the intended behaviour?
There was a problem hiding this comment.
No, I believe the intended behavior is for each global install to use the channels as they were configured at installation time.
There was a problem hiding this comment.
OK. I'll fix this in a separate PR as this one has been merged.
There was a problem hiding this comment.
There is an open issue about this: #1318
Thanks @olivier-lacroix!
tdejager
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors most of
upgrade.rsandupgrade_all.rsinto a commonupgrade_packagesfunction, which upgrades several global packages at once.Now, several global packages can be upgraded at once.