Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow to upgrade several global packages at once #1324

Merged
merged 5 commits into from
May 6, 2024

Conversation

olivier-lacroix
Copy link
Contributor

This PR refactors most of upgrade.rs and upgrade_all.rs into a common upgrade_packages function, which upgrades several global packages at once.

Now, several global packages can be upgraded at once.

}

// Remove possible duplicates
channels = channels.into_iter().unique().collect::<Vec<_>>();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I note channels is common across all global packages. Is this the intended behaviour?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I believe the intended behavior is for each global install to use the channels as they were configured at installation time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I'll fix this in a separate PR as this one has been merged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an open issue about this: #1318

Thanks @olivier-lacroix!

@olivier-lacroix olivier-lacroix marked this pull request as ready for review May 5, 2024 06:50
@tdejager tdejager enabled auto-merge (squash) May 6, 2024 07:37
@tdejager tdejager merged commit dd11ee4 into prefix-dev:main May 6, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants