rattler-build doesn't fail when no license file was found

[pavelzw]

package:
  name: my-name
  version: 0.1.0

about:
  license: MIT
  license_file:
    - LICENSE

❯ rattler-build build -r rb/recipe.yaml
 Target platform: osx-arm64

 ╭─ Finding outputs from recipe
 │ Found 1 variants
 │ Build variant: my-name-0.1.0-h60d57d3_0
 │ ╭─────────────────┬───────────╮
 │ │ Variant         ┆ Version   │
 │ ╞═════════════════╪═══════════╡
 │ │ target_platform ┆ osx-arm64 │
 │ ╰─────────────────┴───────────╯
 │
 ╰─────────────────── (took 0 seconds)

 ╭─ Running build for recipe: my-name-0.1.0-h60d57d3_0
 │
 │ ╭─ Fetching source code
 │ │ No sources to fetch
 │ │
 │ ╰─────────────────── (took 0 seconds)
 │
 │ ╭─ Resolving environments
 │ │
 │ │ Finalized run dependencies: this output has no run dependencies
 │ │
 │ ╰─────────────────── (took 0 seconds)
 │
 │ ╭─ Running build script
 │ │
 │ ╰─────────────────── (took 0 seconds)
 │
 │ ╭─ Packaging new files
 │ │ Copying done!
 │ │ Post-processing done!
 │ │ Writing metadata for package
 │ │ ⚠ warning No include glob matched for copying license files
 │ │ ⚠ warning No license files were copied
 │ │
 │ │ Files in package:
 │ │   - info/about.json
 │ │   - info/hash_input.json
 │ │   - info/index.json
 │ │   - info/paths.json
 │ │   - info/recipe/recipe.yaml
 │ │   - info/recipe/rendered_recipe.yaml
 │ │   - info/recipe/variant_config.yaml
 │ │ Creating target folder "/private/tmp/output/osx-arm64"
 │ │ Compressing archive...
 │ │ Archive written to "/private/tmp/output/osx-arm64/my-name-0.1.0-h60d57d3_0.conda"
 │ │
 │ ╰─────────────────── (took 0 seconds)
 │
 │ ╭─ Running package tests
 │ │ Creating test environment in "/private/tmp/output/bld/rattler-build_my-name_1710498796/work/test"
 │ │ Collecting tests from "/Users/pavel/Library/Caches/rattler/cache/pkgs/my-name-0.1.0-h60d57d3_0"
 │ │
 │ ╰─────────────────── (took 0 seconds)
 │
 ╰─────────────────── (took 0 seconds)

 ╭─ Build summary
 │
 │ ╭─ Build summary for recipe: my-name-0.1.0-h60d57d3_0
 │ │ Artifact: /private/tmp/output/osx-arm64/my-name-0.1.0-h60d57d3_0.conda (1.33 KiB)
 │ │ Variant configuration (hash: h60d57d3_0):
 │ │ ╭─────────────────┬───────────╮
 │ │ │ target_platform ┆ osx-arm64 │
 │ │ ╰─────────────────┴───────────╯
 │ │
 │ │
 │ ╰─────────────────── (took 0 seconds)
 │
 ╰─────────────────── (took 0 seconds)

rattler-build should fail if no license was found imo.

[orhun]

rattler-build should fail if no license was found imo.

Sounds good to me.

Thoughts @wolfv?

[pavelzw]

(that's also the default behavior for conda-build)

[wolfv]

Yes, I think if a license file was specified but not found it should fail.

[orhun]

It turns out license_file can be used as a glob as well. In that case, should we just error out when "No license files were copied" instead of showing a warning?